-
Notifications
You must be signed in to change notification settings - Fork 708
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update v2.11 branch #1698
Merged
Merged
Update v2.11 branch #1698
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jarema
approved these changes
Aug 15, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
piotrpio
force-pushed
the
v2.11-rebase
branch
from
December 13, 2024 15:15
6f590f1
to
a9f64c2
Compare
Signed-off-by: Piotr Piotrowski <[email protected]>
The change is needed to properly operate on mirrored object store buckets. By binding stream nats.go does not need to search for stream by subjects (which does not work for mirrors).
When mirroring Object Store, there is a need to setup subject transformations. However, client also needs to bind to the stream to avoid stream lookup, which is both not necessary and expensive, and also does not work with Object Store mirrors. Signed-off-by: Tomasz Pietrek <[email protected]>
Signed-off-by: Piotr Piotrowski <[email protected]>
Co-authored-by: Paolo TETI <[email protected]>
Signed-off-by: Piotr Piotrowski <[email protected]>
Signed-off-by: Piotr Piotrowski <[email protected]>
…#1582) Signed-off-by: Piotr Piotrowski <[email protected]>
…1586) Signed-off-by: Piotr Piotrowski <[email protected]>
Signed-off-by: Piotr Piotrowski <[email protected]>
…1601) Signed-off-by: Piotr Piotrowski <[email protected]>
Signed-off-by: Piotr Piotrowski <[email protected]>
Signed-off-by: Piotr Piotrowski <[email protected]>
Signed-off-by: Piotr Piotrowski <[email protected]>
…1605) Signed-off-by: Piotr Piotrowski <[email protected]>
Fixes #1579 Signed-off-by: Massimo Costa <[email protected]>
Signed-off-by: Neil Twigg <[email protected]>
Signed-off-by: Piotr Piotrowski <[email protected]>
Signed-off-by: Piotr Piotrowski <[email protected]>
Signed-off-by: Piotr Piotrowski <[email protected]>
Signed-off-by: Jean-Noël Moyne <[email protected]>
…failed (#1619) Signed-off-by: Piotr Piotrowski <[email protected]>
…ntly with the StreamConfig one (#1630) Signed-off-by: Mattia Barbisan <[email protected]>
This fixes an issue where a deadlock could occur when calling `Stop()` or `Drain()` on `ConsumeContext` or `MessagesContext` and then calling `Consume` or `Messages` immediately. Switched to using a type-safe implementation of `sync.Map` for subscriptions map instead of locking the whole consumer state. Additionally, changed the type of atomic flags from `uint32` to `atomic.UInt32` to avoid accidental non-atomic reads/writes. Signed-off-by: Piotr Piotrowski <[email protected]> --------- Signed-off-by: Piotr Piotrowski <[email protected]>
Signed-off-by: Tomasz Pietrek <[email protected]>
Signed-off-by: Piotr Piotrowski <[email protected]> Co-authored-by: Daniel Mack <[email protected]>
Correct README.md formatting
Signed-off-by: Piotr Piotrowski <[email protected]>
* [FIXED] Change Fetch client timeout to a higher value Signed-off-by: Piotr Piotrowski <[email protected]> * Set the maximum diff on timeouts Signed-off-by: Piotr Piotrowski <[email protected]> --------- Signed-off-by: Piotr Piotrowski <[email protected]>
…ription (#1690) Signed-off-by: Piotr Piotrowski <[email protected]>
…closed/drained (#1691) Signed-off-by: Piotr Piotrowski <[email protected]>
Signed-off-by: Piotr Piotrowski <[email protected]>
This reverts commit 94c83b7.
Signed-off-by: Piotr Piotrowski <[email protected]>
Signed-off-by: Piotr Piotrowski <[email protected]>
Signed-off-by: Piotr Piotrowski <[email protected]>
Signed-off-by: Piotr Piotrowski <[email protected]>
Signed-off-by: Piotr Piotrowski <[email protected]>
…idempotent (#1723) Signed-off-by: Jean-Noël Moyne <[email protected]>
The dependencies.md file is important for understanding what linceses are used by nats.go dependencies, however it needed manual operation. This automates it by creating a PR if go.mod dependencies changed. Signed-off-by: Tomasz Pietrek <[email protected]>
Signed-off-by: Piotr Piotrowski <[email protected]>
…d retries (#1719) This fixes an issue in new JetStream API where if maximum number of retries in `PublishMsgAsync` are reached and the publish failed, done and stall channels are not closed. Additionally, this fixes a potential race issue with modifying user msg when publishing. Signed-off-by: Piotr Piotrowski <[email protected]>
…er timeout (#1705) Signed-off-by: Piotr Piotrowski <[email protected]>
Signed-off-by: Piotr Piotrowski <[email protected]>
…e is set (#1742) Signed-off-by: Piotr Piotrowski <[email protected]>
1. The info about pre go modules is not relevant anymore, so drop it. 2. Extra slashes are not needed before the version suffix, per https://go.dev/ref/mod#go-install. So make it consistent. Signed-off-by: Alex Bozhenko <[email protected]>
Signed-off-by: Yordis Prieto <[email protected]>
Signed-off-by: Piotr Piotrowski <[email protected]>
piotrpio
force-pushed
the
v2.11-rebase
branch
from
December 13, 2024 15:20
a9f64c2
to
84608cc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Piotr Piotrowski [email protected]